Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the documents of dataflow #148

Merged
merged 8 commits into from
Dec 16, 2024

Conversation

MightyGaga
Copy link
Contributor

No description provided.

@vyokky vyokky requested a review from Copilot December 16, 2024 03:35
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 11 changed files in this pull request and generated 1 comment.

Files not reviewed (6)
  • dataflow/schema/execution_schema.json: Language not supported
  • documents/docs/dataflow/result_schema.md: Evaluated as low risk
  • dataflow/data_flow_controller.py: Evaluated as low risk
  • dataflow/env/env_manager.py: Evaluated as low risk
  • documents/docs/dataflow/windows_app_env.md: Evaluated as low risk
  • documents/mkdocs.yml: Evaluated as low risk
Comments suppressed due to low confidence (1)

dataflow/execution/workflow/execute_flow.py:322

  • The indentation of the 'if control_selected' block is incorrect. It should be aligned with the assignment of 'self._control_label, control_selected' to ensure proper execution flow.
if control_selected:

@@ -1,9 +1,13 @@
# Execution

The instantiated plans will be executed by a execute task. After execution, evalution agent will evaluation the quality of the entire execution process.
The instantiated plans will be executed by a `execute` task. After execution, `evalution` agent will evaluation the quality of the entire execution process.
Copy link
Preview

Copilot AI Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term evalution should be evaluation.

Suggested change
The instantiated plans will be executed by a `execute` task. After execution, `evalution` agent will evaluation the quality of the entire execution process.
The instantiated plans will be executed by a `execute` task. After execution, `evaluation` agent will evaluation the quality of the entire execution process.

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@vyokky vyokky merged commit d4a2c8f into microsoft:pre-release Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants